Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to implment async loading? #22

Closed
darklinkpower opened this issue Sep 8, 2019 · 9 comments
Closed

Is it possible to implment async loading? #22

darklinkpower opened this issue Sep 8, 2019 · 9 comments

Comments

@darklinkpower
Copy link

Just wondering if it's possible to use implement it, since from what I see it's the main cause for performance issues. A solution to this could be using async loading, where it loads the images after you have scrolled, that way there's no performance impact and it's smooth when scrolling.

@Ottodix
Copy link
Owner

Ottodix commented Sep 10, 2019

Hi,
Which panel? I'm in holiday right now, but it's supposed to be smooth when you scroll, the image loading is delayed (not async though). I could make it completely async yes, but then it will probably be slower. I'll probably take a look later, maybe there is a way to improve it using an async function

@darklinkpower
Copy link
Author

darklinkpower commented Sep 10, 2019

For the panel with all the album covers, even when in high performance mode and in charge mode I experience noticeable lagging, and when on battery mode it's like in slow-mo for me. Do you know what the issue could be?
These are my laptop specs
CPU: intel 4710HQ (6M Cache, up to 3.50 GHz)
iGPU: intel 4400HD
RAM: 8GB DDR3

I have tried using different image cache options and cover sizes with no improvement sadly, any idea why this might be happening?

@Ottodix
Copy link
Owner

Ottodix commented Sep 11, 2019

Weird, your laptop is better than mine... maybe you've got a very very large music library ? How large in memory is the foobar process on the task manager ?

@Ottodix
Copy link
Owner

Ottodix commented Sep 11, 2019

I implemented a async method, it loads the covers a lot faster on my computer when you scroll. But I can't say that it won't lag because I never experienced any lags myself. I wonder, do you have an ssd? It may be a lot slower without one.

You can try the latest the nighly build.

@darklinkpower
Copy link
Author

Yeah I have a very large library, almost 10k songs I think. It's noticeably better in the nightly since I can scroll on most lists fine when in high performance, awesome.

My HDD is on the slow side, 5400RPM. but I don't know if the issue is loading data, I thought it was just when scrolling down but it's not the case; I just noticed that there's a general slowdown in everything once there's a considerable amount of tracks in the playlist, the more, the slowdown is worse. For example, I notice that any action, like opening an album, simply selecting a song inside an album, etc, takes around double the time compared to a less populated playlist.
imagen

@Ottodix
Copy link
Owner

Ottodix commented Sep 12, 2019

10k songs is less than mine, i've got 28k songs. Your foobar memory is high, but nothing completely unusual for this theme.
This async loading of covers seems to work, so I close the ticket now. I'll let you know there if I find other ways to improve the performances later, but for the moment I've got no idea, sorry !

@Ottodix Ottodix closed this as completed Sep 12, 2019
@Ottodix
Copy link
Owner

Ottodix commented Sep 13, 2019

You can try the newest nightly build. To be honest, it may or may not change anything, I'm not confident about the effect it will have (but it can only be better though !).

@darklinkpower
Copy link
Author

Nice work! I just tried for a few minutes and it works much better without a doubt, there's no freezes anymore, like at all and I can use it fine when in high performance, both unplugged and plugged, although still no luck in low performance mode.

The only thing I can see is that the higher the group count in the album cover panel, the interface, while not freezing, lowers the fps (don't know if it's the correct term to use here). Everything now feels responsive, no freezing but the screen update time is not fluid. I don't know if I'm explaning myself.

All in all, now I can use Eole thanks to the recent changes you made. Thanks a lot :)

@Ottodix
Copy link
Owner

Ottodix commented Sep 13, 2019

Yes, about this issue when there is a lot of covers displayed, I can think of possible improvements.

And about the memory too, I can still think of a possible improvement, like a mini minimum cover memory mode. Maybe I'll code it later, but I don't know when though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants