Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini player white progress bar bug #3

Closed
mjuzikfrik opened this issue May 17, 2019 · 8 comments
Closed

Mini player white progress bar bug #3

mjuzikfrik opened this issue May 17, 2019 · 8 comments

Comments

@mjuzikfrik
Copy link

mjuzikfrik commented May 17, 2019

Hello,

I get an error mentioned below when I want to set playlist progress bar to white in the mini mode.

Error: Spider Monkey Panel v1.2.1 (MiniModePlaylist v1.0.0 by Ottodix)
progressbar_color_bg_off is not defined

File: WSHsmoothplaylist.js
Line: 2947, Column: 13

Stack trace:
  oBrowser/this.draw@WSHsmoothplaylist.js:2947:13
  on_paint@WSHsmoothplaylist.js:4693:16

edit. Same happens with right playlist. Also is it normal for cover to disappear from the right when I select transparent background or blurred for the main tracklist?

@Ottodix
Copy link
Owner

Ottodix commented May 19, 2019

Hi!

My guess is that you've got some out of dates files. This variable, progressbar_color_bg_off, doesn't appears anymore in this file, WSHsmoothplaylist.js. Just update the theme.
In a future version, i will include a version number directly in the error messages, because fixing issues from out of date version is impossible.

About your other question, i would say: first update the whole theme : ) And then if the issue is still there, make sure that you are using the wallpaper menu from the individual panels settings available with a right click > settings..., and not the wallpaper menu item available through foobar > skin settings > panel layout > wallpapers

@Ottodix Ottodix closed this as completed May 19, 2019
@mjuzikfrik
Copy link
Author

mjuzikfrik commented May 19, 2019

I downloaded the latest version from github. I made another new install, followed your hints and it still occurs. What's interesting is that the version before it - the 1.0.0 - is free from this issue.

edit. The cover on the right doesn't disappear too when changing background to for example transparent.

@Ottodix
Copy link
Owner

Ottodix commented May 19, 2019

I'm sorry, but this is simply not possible, you are doing something wrong while doing your update. This variable, progressbar_color_bg_off, doesn't appears anymore in any of the files of this theme.

And with the background issue, i don't understand your issue neither. At least please provide me a clear step by step in order to reproduce your issue (where do you click, which menu items, etc...)

@mjuzikfrik
Copy link
Author

Foobar2000 1.4.4. fresh portable install, latest version of Eole from github.
1
2

@Ottodix
Copy link
Owner

Ottodix commented May 20, 2019

For the first error, related to the right playlist: It says it right on your error message that your theme is out of date: "RightPlaylist v1.0.0". Current version was 1.0.2, and i just updated it to 1.0.3a. Please update, and import again the columnUI file. And I repeat: your error message explain that the code is looking for a variable which doesn't exist ANYWHERE in the code. So, it really means that your foobar is using a older version of some of the js files, and this isn't a maybe. Please trust me, and make sure that your foobar is using the right files. My guess is that you are still using version 1.0.1. Reporting an issue is fine, but please try to follow my instructions.

For the second , i finaly understood what you are talking about. I fixed the error in the latest version, thanks for reporting.
https://github.com/Ottodix/Eole-foobar-theme/releases/tag/1.0.3b

@mjuzikfrik
Copy link
Author

I'm really sorry. For some reason I didn't see anything beyond 1.0.1. It works as expected now, though with 1.0.3b I have something like that.
1

@mjuzikfrik
Copy link
Author

It looks like it's working now. Thanks!

@Ottodix
Copy link
Owner

Ottodix commented May 24, 2019

Ok, great!

Ottodix pushed a commit that referenced this issue Nov 10, 2019
Bug fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants