Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checks for VT #155

Merged
merged 4 commits into from
Sep 11, 2019
Merged

Added checks for VT #155

merged 4 commits into from
Sep 11, 2019

Conversation

jeremiahdsouza
Copy link
Contributor

Fixes # .

Changes proposed in this pull request:

  • Added checks for VT in ssh.js
  • Added await keyword to checkVirt calling statement
  • Modified printing condition

@jeremiahdsouza
Copy link
Contributor Author

The first condition checks if the system support 64 bit computing(64 bit Intel or AMD cpu). The next one checks if the system supports VT by checking if the svm or vmx flags are present which implies that VT is supported. From what I read online, the last condition checks if VT is actually enabled.

@jeremiahdsouza
Copy link
Contributor Author

The second check itself may prove to be sufficient, but I wasn't sure due to this unresolved thread :
https://askubuntu.com/questions/103965/how-to-determine-if-cpu-vt-extensions-are-enabled-in-bios

@jeremiahdsouza
Copy link
Contributor Author

Modified the function to check only for VMX or SVM flags

@ssmirr ssmirr self-requested a review September 11, 2019 13:38
Copy link
Contributor

@ssmirr ssmirr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @JerryD10 🚀

@ssmirr ssmirr merged commit e256732 into ottomatica:dev Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants