Require scheme in origins #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wgonczaronek do you want to give this a check? |
wgonczaronek
approved these changes
May 10, 2019
|
Perfect! I'll just fix up the code style, do some other tidy up I have planned, merge and release! |
adamchainz
force-pushed
the
issue_379_enforce_scheme
branch
from
5931b32
to
3745968
Compare
This "upgrades" the change in #388 to *require* scheme, rather than going through a deprecation period. It simplifies the code greatly. I added checks as well to ensure that `CORS_ORIGIN_WHITELIST` is well-formed, so that users upgrading will see some obvious errors.
adamchainz
force-pushed
the
issue_379_enforce_scheme
branch
from
3745968
to
48d0209
Compare
This was referenced May 10, 2019
|
Hi, I just wanted to thank you for adding the check and |
|
@leibowitz no worries, thanks for your message of encouragement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "upgrades" the change in #388 to require scheme, rather than going through a deprecation period. It simplifies the code greatly.
I added checks as well to ensure that
CORS_ORIGIN_WHITELISTis well-formed, so that users upgrading will see some obvious errors.