Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Please increase the accuracy of QR code detection to detect 1 cm x 1 cm screenshots of qr code on screen #4

Open
blue-pine opened this issue May 6, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@blue-pine
Copy link

Please increase the accuracy of QR code detection as same Qr code pic of 1 cm x 1 cm when scanned by google lens finds the link present in qr code but can't be detected by this app until I increase the size of qr code by zooming to 2 cm x 2cm which takes a lot of space for example when reading a pdf and the page in pdf then gets overzoomed hiding most part of it

@blue-pine blue-pine added the bug Something isn't working label May 6, 2024
@ottozumkeller
Copy link
Owner

Thank you for your feedback. Depending on the resolution of your screen, it may be that the qr code is simply too small to be read, as QR Code Reader relies on a screenshot for decoding. Can you attach a screenshot?

@blue-pine
Copy link
Author

blue-pine commented May 9, 2024

Thank you for your feedback. Depending on the resolution of your screen, it may be that the qr code is simply too small to be read, as QR Code Reader relies on a screenshot for decoding. Can you attach a screenshot?

Glad for supporting me . Here's the qr screenshot
Screenshot 2024-05-09 194531

Here's a full screenshot to get an idea of full screen resolution 1080p

Screenshot 2024-05-09 195129

@ottozumkeller
Copy link
Owner

Thank you for your screenshot. I made a quick adjustment and it should work now. I have implemented a few improvements (mainly in speed). I'm just waiting for the result of windows defender security intelligence to release the next version.

@blue-pine
Copy link
Author

blue-pine commented May 10, 2024

Thank you for your screenshot. I made a quick adjustment and it should work now. I have implemented a few improvements (mainly in speed). I'm just waiting for the result of windows defender security intelligence to release the next version.

Thank you so much. Very grateful. Considering your swift care for users you should be popular for your contribution.
Also, Is the upgrade available to download now without the result from security intelligence, as i have no idea if it is some restriction on github before publishing a new release to download, is it ? Can you shed some light on this intelligence , why its required ? as I am also hoping to see how github is used professionally for software deployment

@ottozumkeller
Copy link
Owner

A Windows Defender result or other virus scan is not necessary to create a release on github. It is only very inconvenient for you as a user if the msi file is recognized as a virus and removed immediately after downloading. Nevertheless, you can of course still download the repository and create QR-Code Reader yourself. You just have to execute the file "build.bat" in the folder "Build" and the msi file will be generated. Hopefully that helps.

@blue-pine
Copy link
Author

A Windows Defender result or other virus scan is not necessary to create a release on github. It is only very inconvenient for you as a user if the msi file is recognized as a virus and removed immediately after downloading. Nevertheless, you can of course still download the repository and create QR-Code Reader yourself. You just have to execute the file "build.bat" in the folder "Build" and the msi file will be generated. Hopefully that helps.

Thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants