Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the scope of some flags #327

Open
marcospb19 opened this issue Dec 24, 2022 · 0 comments
Open

Reduce the scope of some flags #327

marcospb19 opened this issue Dec 24, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@marcospb19
Copy link
Member

Flags like --hidden and --gitignore are set in the Opts struct,
however, they are specific to the compress subcommand, so these
flags should be moved to the Subcommand::Compress enum variant.

ouch/src/opts.rs

Lines 28 to 34 in 5a97029

/// Ignores hidden files
#[arg(short = 'H', long)]
pub hidden: bool,
/// Ignores files matched by git's ignore files
#[arg(short = 'g', long)]
pub gitignore: bool,

This will hide those flags when using Ouch with other commands.

@marcospb19 marcospb19 added the enhancement New feature or request label Dec 24, 2022
@marcospb19 marcospb19 changed the title Reduce the subcommand scope of some flags Reduce the scope of some flags Dec 24, 2022
@marcospb19 marcospb19 added the good first issue Good for newcomers label Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant