Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for zstd #44

Closed
djc opened this issue Jul 25, 2021 · 2 comments · Fixed by #64
Closed

Add support for zstd #44

djc opened this issue Jul 25, 2021 · 2 comments · Fixed by #64
Labels
enhancement New feature or request medium priority

Comments

@djc
Copy link

djc commented Jul 25, 2021

Would be nice to have. Especially if it defaulted to multithreaded operation (unlike upstream).
@vrmiguel vrmiguel added the enhancement New feature or request label Jul 25, 2021
@marcospb19
Copy link
Member

Seems to be viable, docs.rs/zstd has the decoders that we need, however, they don't support multiple threads.

@marcospb19
Copy link
Member

Status update: I implemented it but got a linker error, could not solve it and got busy with other stuff.

I'm optimistic that it is a solvable error, however, I haven't figured it out yet, and if it requires a new library to be installed, we would need to stick to the musl toolchain, this could force us to drop support for some platforms.

@vrmiguel vrmiguel mentioned this issue Oct 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Zstd ouch-org/ouch
3 participants
@djc @vrmiguel @marcospb19