Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run logging IO in a separate thread (improve multithread capabilities) #643

Closed
marcospb19 opened this issue Mar 13, 2024 · 0 comments · Fixed by #642
Closed

Run logging IO in a separate thread (improve multithread capabilities) #643

marcospb19 opened this issue Mar 13, 2024 · 0 comments · Fixed by #642
Labels
enhancement New feature or request

Comments

@marcospb19
Copy link
Member

Bringing some discussion from #632 to this dedicated issue.

Problem

The way we currently handle STDIN and STDOUT can cause synchronization problems: #510 is a terrible bug.

The issue above is also a reason why we can't have progress bars back: #632.

Besides bugs and features, it also causes performance problems: #77, our worker threads block progress to do blocking IO.

Solution

@AntonHermann came up with a solution (sent in #632's discussion):

image

Basically, this enables us to solve all the previously listed issues!

Again, discussion and more details can be found at #632.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant