Mostly memory management #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove all owning raw pointers - Replace all calls to new with make_unique - Use CRTP for generating Clone method
Dependant name lookup is a Microsoft extension
|
@Guekka Please remove "Utils.hpp" and put the changes into "NifUtil.hpp" instead. No need for two util headers. Additionally, don't include "Utils.hpp" in any other header files, we don't want to force the templates on anyone using nifly. If necessary, move GetBlockID to a source file and split the clone stuff into its own header so that you can include it in other headers if necessary. |
- Split Utils.hpp into NifUtil.hpp and CloneInherit.hpp - Avoid include NifUtil in headers
|
@ousnius Is it good like that? |
ousnius
reviewed
Mar 8, 2021
Comment on lines
+1410
to
+1411
| hdr.ReplaceBlock(GetBlockID(shape), std::unique_ptr<NiObject>(std::move(bsOptShape))); | ||
| UpdateSkinPartitions(bsOptShape.get()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For review, I suggest looking at each commit individually.
For 05db039 (memory management), I suggest you do not look at the headers. It's only noise, the real changes are in the source files
Going to test the changes soon