Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newlines in annotations aren't escaped in preview #74

Closed
ngirard opened this issue Apr 13, 2021 · 12 comments · Fixed by #80
Closed

Newlines in annotations aren't escaped in preview #74

ngirard opened this issue Apr 13, 2021 · 12 comments · Fixed by #80
Labels
bug Something isn't working

Comments

@ngirard
Copy link

ngirard commented Apr 13, 2021

Using home-made binary from the trunk, on Ubuntu 20.04.
Here's an example output of gooseberry search:

Screenshot_20210413_164714

Installed the very last version of Bat, to no effect.

@ngirard ngirard added the bug Something isn't working label Apr 13, 2021
@Ninjani
Copy link
Member

Ninjani commented Apr 13, 2021

Is bat working on other markdown files with the settings bat -l markdown --color=always -p?

@ngirard
Copy link
Author

ngirard commented Apr 13, 2021

Is bat working on other markdown files with the settings bat -l markdown --color=always -p?

My bad, I misread you and thought these options had to be added somewhere in Gooseberry's config.

Sure, Bat displays my markdown files just fine. There's nothing related to Bat or a custom pager in my configuration (as far as I could check).

@Ninjani
Copy link
Member

Ninjani commented Apr 13, 2021

Hmm, okay let's try to narrow down what's causing this - do you see the same thing happening when you run gooseberry view? (Probably a good idea to filter to a particular pattern/day so your terminal isn't filled with output)

@ngirard
Copy link
Author

ngirard commented Apr 13, 2021

do you see the same thing happening when you run gooseberry view?

I don't.

@Ninjani
Copy link
Member

Ninjani commented Apr 13, 2021

Okay, then it seems to be a skim issue. The relevant function is here - could you try removing the "-p" in the command and see what change that has?

@Ninjani
Copy link
Member

Ninjani commented Apr 13, 2021

Oh wait, why is that a {:?}!

@Ninjani
Copy link
Member

Ninjani commented Apr 13, 2021

Okay, I think I tried to get away with not escaping newlines etc by using {:?} but guess that doesn't work on Ubuntu sigh.

@Ninjani
Copy link
Member

Ninjani commented Apr 13, 2021

"echo \"{}\" | bat -l markdown --color=always -p",

Can you try this (on line 60)?

@ngirard
Copy link
Author

ngirard commented Apr 13, 2021

I was expecting the worst... but it worked ! Well done !

@Ninjani
Copy link
Member

Ninjani commented Apr 13, 2021

Haha great! I should probably figure out how to test interactivity across devices but until then I'm really appreciating these issues, will be in the next release.

@ngirard
Copy link
Author

ngirard commented Apr 13, 2021

Well then, I'd appreciate you pushed a new release, to spare me with the build --release. But if not, no big deal !

@Ninjani
Copy link
Member

Ninjani commented Apr 13, 2021

Well then, I'd appreciate you pushed a new release

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants