go get github.com/outcaste-io/ristretto@v0.2.0 doesn't seem to get the tagged version?

[nik-andreev]

Maybe it was just me but when I do go get github.com/outcaste-io/ristretto@v0.2.0 it doesn't get the code that I see in https://github.com/outcaste-io/ristretto/blob/v0.2.0/go.mod

Specifically the one that I download includes golang/glog

My workaround was to specify the commit (bd658a4) as go.mod/replacement

replace github.com/outcaste-io/ristretto v0.2.0 => github.com/outcaste-io/ristretto v0.1.1-0.20220420003845-bd658a460d49

In the meantime this is what I have in my ~/go/pkg/ directories

~/go/pkg/mod/github.com/outcaste-io/ristretto@v0.2.0 $ cat go.mod 
module github.com/outcaste-io/ristretto

go 1.12

require (
        github.com/cespare/xxhash/v2 v2.1.1
        github.com/davecgh/go-spew v1.1.1 // indirect
        github.com/dgryski/go-farm v0.0.0-20190423205320-6a90982ecee2
        github.com/dustin/go-humanize v1.0.0
        github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
        github.com/pkg/errors v0.9.1
        github.com/stretchr/testify v1.4.0
        golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f
)

vs the commit hash version

~/go/pkg/mod/github.com/outcaste-io/ristretto@v0.1.1-0.20220420003845-bd658a460d49 $ cat go.mod
module github.com/outcaste-io/ristretto

go 1.12

require (
        github.com/cespare/xxhash/v2 v2.1.1
        github.com/dgryski/go-farm v0.0.0-20190423205320-6a90982ecee2
        github.com/dustin/go-humanize v1.0.0
        github.com/pkg/errors v0.9.1
        github.com/stretchr/testify v1.7.0
        go.uber.org/atomic v1.9.0
        golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f
)

I'm not sure what the exact problem is though 🤷

[github-actions]

Use Discuss Issues for reporting issues about this repository.

[nik-andreev]

@manishrjain, seems like github actions automatically closed the issue and points to dgraph-io. Yet, from what I understand the whole point of the fork is that you don't have relationship with dgraph-io anymore.

[manishrjain]

Hey @nik-andreev ,

I just tagged v0.2.1. When I go get it, I get this go.mod

module test2

go 1.18

require (
	github.com/cespare/xxhash/v2 v2.1.1 // indirect
	github.com/dustin/go-humanize v1.0.0 // indirect
	github.com/outcaste-io/ristretto v0.2.1 // indirect
	github.com/pkg/errors v0.9.1 // indirect
	go.uber.org/atomic v1.9.0 // indirect
	golang.org/x/sys v0.0.0-20220627191245-f75cf1eec38b // indirect
)

Seems to be giving the expected results. So, try with v0.2.1?

[nik-andreev]

Thank you for the speedy response! And yes, v0.2.1 seems to be working as expected.