Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.1.0 BC break with ZF2 #12

Closed
athlan opened this issue Jun 22, 2017 · 5 comments
Closed

Version 2.1.0 BC break with ZF2 #12

athlan opened this issue Jun 22, 2017 · 5 comments
Assignees

Comments

@athlan
Copy link

athlan commented Jun 22, 2017

Releare 2.1.0 breaks backward compability with ZF2, because of commit:
bfa6f7a

In ZF 2.3.1 there is no Zend\ServiceManager\Factory\FactoryInterface;, instead of this there is Zend\ServiceManager\FactoryInterface;

In my opinion, version 2.1.0 should be 3.x.

@davidwindell
Copy link
Member

@athlan You're quite right. Are you able to raise a PR that uses the Zend\ServiceManager\FactoryInterface shim so that we can support both ZF2 and ZF3?

https://github.com/zendframework/zend-servicemanager/blob/master/src/FactoryInterface.php

athlan added a commit to athlan/SwaggerModule that referenced this issue Jun 27, 2017
athlan added a commit to athlan/SwaggerModule that referenced this issue Jun 27, 2017
@athlan
Copy link
Author

athlan commented Jun 27, 2017

Pull request (#13) has been prepared.

@davidwindell
Copy link
Member

Thanks @athlan, I'll review this early next week for you.

@davidwindell davidwindell self-assigned this Jun 30, 2017
@athlan
Copy link
Author

athlan commented Jul 14, 2017

Bump.

@davidwindell
Copy link
Member

Fixed in 70ebf54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants