Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null values being saved as 'null' string #49

Closed
mstyles opened this issue Jul 20, 2020 · 2 comments
Closed

Null values being saved as 'null' string #49

mstyles opened this issue Jul 20, 2020 · 2 comments

Comments

@mstyles
Copy link
Contributor

mstyles commented Jul 20, 2020

For nullable fields which do not saveAsJSON, if the value is null it was being encoded and turned into a 'null' string. I am using the latest version (1.9.0). This issue was reported previously but was closed (#30), so I'm recreating it (feel free to close this one if we don't want a duplicate). I've submitted a fix here: #48

Originally posted by @mstyles in #30 (comment)
@Tarpsvo
Copy link
Collaborator

Tarpsvo commented Jul 21, 2020

Thanks a lot! I merged your PR and released it in version 1.9.1. Good luck!

@Tarpsvo Tarpsvo closed this as completed Jul 21, 2020
@mstyles
Copy link
Contributor Author

mstyles commented Jul 21, 2020

Wow, thanks for such a quick response and new release! I appreciate it 🥰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mstyles @Tarpsvo