Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tasks completion on document list items #2320

Closed
tommoor opened this issue Jul 14, 2021 · 5 comments · Fixed by #2342
Closed

Show tasks completion on document list items #2320

tommoor opened this issue Jul 14, 2021 · 5 comments · Fixed by #2342
Labels
enhancement It would be nice if…

Comments

@tommoor
Copy link
Member

tommoor commented Jul 14, 2021

It would be neat to expose a preview of the completed checklist items on documents, see how it's done in a couple of other products:

Prior art

Linear

image

GitHub

image

@tommoor tommoor added the enhancement It would be nice if… label Jul 14, 2021
@iamsaumya
Copy link
Collaborator

Regex matching for - [ ] and - [x] will do here, right?

@tommoor
Copy link
Member Author

tommoor commented Jul 17, 2021

I think that's the way to go for now, there's a starting point for that here:
https://github.com/outline/rich-markdown-editor/blob/main/src/lib/markdown/checkboxes.ts#L4

Thoughts on exposing this info via API? Eg a tasks key on the document response – could be kind of fun to have that information available to other API consumers 🤔

@iamsaumya
Copy link
Collaborator

Let's do it.

@iamsaumya iamsaumya added this to the Release v0.58.0 milestone Jul 18, 2021
@iamsaumya
Copy link
Collaborator

Should we install this package for the progress bar?

@tommoor
Copy link
Member Author

tommoor commented Jul 19, 2021

I think it's a bit much, we can achieve this effect with quite a simple SVG component actually – here's an example:

https://dev.to/jackherizsmith/making-a-progress-circle-in-react-3o65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement It would be nice if…
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants