Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed links are recreated after saving file when paragraph text is an URL #2332

Closed
willipjr opened this issue Jul 16, 2021 · 3 comments
Closed
Labels
blocked Something elsewhere needs changing first bug editor stale

Comments

@willipjr
Copy link

To Reproduce

  1. Paste an URL in a paragraph in the document editor;
  2. Double-click the link and click the trash can icon to remove it;
  3. Save the document;
  4. Check out the document page.

Expected behavior
Since the option to remove the link from the text is given to the user, the URL should be kept as plain text after the document is saved if they do it.

Screenshot
https://youtu.be/bZyJzZy8h7U

Outline

  • Install: self hosted;
  • Version: outlinewiki/outline:version-0.57.0 docker image
@willipjr willipjr added the bug label Jul 16, 2021
@tommoor
Copy link
Member

tommoor commented Jul 16, 2021

Due to the nature of auto linking this might not be possible to fix with Markdown as the canonical source.

For a workaround I'd recommend wrapping in a code mark to prevent auto-linking.

As an aside – with the upcoming addition of collaborative editing we'll be moving away from Markdown as the canonical storage format by necessity. This will open up a lot of options and likely make fixing this issue more possible.

@tommoor tommoor added blocked Something elsewhere needs changing first editor labels Aug 24, 2021
@stale
Copy link

stale bot commented Nov 22, 2021

Hey! The issue has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs. Please reply here if you wish for the issue to be kept open.

@stale stale bot added the stale label Nov 22, 2021
@tommoor
Copy link
Member

tommoor commented Nov 30, 2021

This is fixed by using v0.60.2 and enabling the collaborative editing feature, which no longer uses Markdown as the canonical data source.

@tommoor tommoor closed this as completed Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something elsewhere needs changing first bug editor stale
Projects
None yet
Development

No branches or pull requests

2 participants