Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tldraw integration does not show content #6706

Open
glungtung opened this issue Mar 24, 2024 · 8 comments
Open

tldraw integration does not show content #6706

glungtung opened this issue Mar 24, 2024 · 8 comments
Labels

Comments

@glungtung
Copy link

On my v0.75.2 self-hosted outline, when I insert a tldraw link in my outline document, or when i use /tldraw integration with my tldraw link, i have a white frame with a "Visit this page on tldraw.com" link. The link is working properly, but i don't see tldraw content in the integrated frame
I've tried this with different tldraw document type : shared link, read-only link, snapshot link

To Reproduce
Steps to reproduce the behavior:

  1. type /tldraw, enter
  2. paste my tldraw document link

Expected behavior
a frame with my tldraw document content

Screenshots
If applicable, add screenshots or videos to help explain your problem.
Capture d’écran 2024-03-24 à 11 17 09

Outline (please complete the following information):

  • Install: self hosted
  • Version: v0.75.2

Desktop (please complete the following information):

  • OS: macos
  • Browser : firefox, safari and chrome = same behavior
@glungtung glungtung added the bug label Mar 24, 2024
Copy link

linear bot commented Mar 24, 2024

@tommoor
Copy link
Member

tommoor commented Mar 25, 2024

It seems as though tldraw may have blocked embeds entirely, checking with their team…

@glungtung
Copy link
Author

I found a working embed there : https://tldraw.dev/

@Squiddim
Copy link

Squiddim commented Apr 6, 2024

Hi this issue Stems from tldraw Side blocking iFrame integration of their Hosted version. I suggest natively integrating their SDK into the Codebase
also see #4174

@tommoor
Copy link
Member

tommoor commented Apr 7, 2024

Yes, I'm talking to the founder of TLDraw – this is likely a temporary limitation on their side while they figure out how to make embeds enabled again without inviting abuse.

@Squiddim
Copy link

Squiddim commented Apr 7, 2024

@tommoor Thx for looking into this matter :)
but why not integrate their SDK imho thats what tldraw is designed to do instead of relying on their hosted service?
The other discussion about this problem is 2 years old so maybe they just dont want ppl to do this
from my perspective wanting to selfhost the entire wiki i find it counterproductive to rely on tldraws hosted instance for my data

@elysweyr
Copy link

elysweyr commented Apr 7, 2024

Yes, I'm talking to the founder of TLDraw – this is likely a temporary limitation on their side while they figure out how to make embeds enabled again without inviting abuse.

Thanks! Integrating tldraw would be indeed very neat but I wouldn’t expect that much from negotiations. That’s because they’ve changed course very drastically (went de-facto closed source). Therefore I would suggest to fork the last version of tldraw published under Apache license and ditch copyright infringing material.

It’s very hard to build open source software based on closed source components with very harsh usage limitations.

What do you think? @tommoor

(Disclaimer: this activity is purely dedicated to my free time projects and not related in any way to my employment.)

See:
https://github.com/tldraw/tldraw/blob/main/LICENSE.md
https://github.com/tldraw/tldraw/blob/6bd7f4fcc97bbecda6785968c64c2814ea25452f/LICENSE

@tommoor
Copy link
Member

tommoor commented Apr 8, 2024

The current integration is just a quick way for folks to preview TLDraw links within Outline. The maintainer has suggested they plan on re-enabling this iframing (source) once abuse has been dealt with (understandable).

While there might be some thought behind integrating a fully integrated drawing interface into Outline that would be a much larger project, especially as Outline has it's own multiplayer framework, storage requirements, etc.

FWIW I'm not dogmatic about OSS here – we integrate with lots of commercial products because the reality is these often have a better UX and larger user numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants