Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading memory consumption bar chart #27

Closed
cornerman opened this issue Jan 20, 2018 · 6 comments
Closed

Misleading memory consumption bar chart #27

cornerman opened this issue Jan 20, 2018 · 6 comments
Assignees
Milestone

Comments

@cornerman
Copy link
Contributor

The readme shows a bar chart comparing memory consumption of scribe and scala logging. As the y-axis is cut off at some arbitrary value (590... which unit btw?),i it makes the difference seem enormous while in reality it is much smaller.

I really like this library and the performance information provided is nice, but I think we should show the data in an honest way. When recommending the library to other people, I already got negative feedback about this chart. Can we change this?

@darkfrog26
Copy link
Contributor

I don't disagree with you, but there wasn't any malicious intention behind it. I simply plugged the values into a chart generator and that's how it represented the values. If you'd like to provide alternative graphs I'd happily replace them. I believe it was https://www.onlinecharttool.com/ that I used.

@darkfrog26
Copy link
Contributor

chart

Is this a more representative image? I'm going to be releasing Scribe 2.0 this week and want to make sure the visualizations (coming from JMH) don't come across as misleading.

@darkfrog26 darkfrog26 self-assigned this Jan 30, 2018
@darkfrog26 darkfrog26 added this to the 2.0 milestone Jan 30, 2018
@cornerman
Copy link
Contributor Author

@darkfrog26 Nice! The numbers look very good, too. Did something significantly change? And where is scibe-async coming from? :)

@darkfrog26
Copy link
Contributor

Scribe 2.0 (you can see it in the "2.0" branch) is a complete re-write of Scribe with a focus on performance. It also adds a "scribe-extras" module for asynchronous write operations (since it adds a dependency to Akka).

@darkfrog26
Copy link
Contributor

Scribe 2.0 has been released and all new charts and graphs have been created. Please confirm you agree these are in no way misleading and close this ticket. Thanks!

@cornerman
Copy link
Contributor Author

Great and now I am really looking forward to trying out the new release!

Thanks for taking care of this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants