Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snabbdom fork and depend on our released npm version #447

Open
cornerman opened this issue Sep 10, 2020 · 2 comments
Open

Update snabbdom fork and depend on our released npm version #447

cornerman opened this issue Sep 10, 2020 · 2 comments

Comments

@cornerman
Copy link
Member

No description provided.

@cornerman cornerman added this to the 1.0 milestone Sep 10, 2020
@busti
Copy link
Collaborator

busti commented Sep 27, 2020

Do you happen to know what the maintenance mode for mainline snabbdom is?
Do they make major changes to the codebase and functionality regularly, or do they just make fixes and add minor features here and there? The repo seems rather active.
If so maybe we could accumulate our required changes into a series of git .patch files and apply them automatically to mainline snabbdom.

@cornerman
Copy link
Member Author

Working with a patch file and automatically using mainline snabbdom would be awesome! I remember that we have removed some parts of the API to make it smaller and also removed some unnessecarry code paths. Apart from that we made some changes in the diffing, notably making patching more efficient when VNode are reused so we can remove the need for diffing whole subtrees that we know will anyway be the same.

I really need to look into the changes of snabbdom in more detail, but afaik it is mostly small changes or updates.

@fdietze fdietze removed this from the 1.0 milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants