Rename EmitterBuilder.mapResult -> mapModifier ?

[fdietze]

outwatch/outwatch/src/main/scala/outwatch/EmitterBuilder.scala

Line 243 in 06c4cca

@inline def mapResult[S](f: R => S): EmitterBuilderExecution[O, S, Exec] =

[cornerman]

In understand it, but currently an emitterbuilder could also return a VNode or something totally different. mapModifier would not capture that. Is there a better name that leaves that open?

[fdietze]

what else can it return that is not a VModifier?

[cornerman]

Everything, that can own a subscription :)

[fdietze]

Sounds a bit too generic to me. Is there a good use-case?

[cornerman]

One example, the typeclass allows us to return any Functor, like an Option, a List or IO of a Modifier as a result. Furthermore, you could also return something totally different like an Observable[Something], because they can also own a subscription. I had a use-case once - though not very common.

[cornerman]

I guess, it is debatable whether we need to support that - but I did not see a reason why not. We anyhow need to keep it generic to have a distinction between VNode and VModifier.

[cornerman]

Do we have a better name than mapResult that stays generic?

[fdietze]

mapContainer, mapOwner, something like that? Result is misleading imho.

[cornerman]

Hmm, though Owner is already used for reactive ownership, not sure whether we should mix this here. Container is interesting, but also not really intuitive to me.

I thought, result was good, because it is a builder and that typically has a result (what you get when you assign an observer with --> or foreach). The idea was to reuse that vocabulary.