Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bench subproject and make sure it builds correctly in CI. #695

Open
busti opened this issue Feb 22, 2023 · 2 comments
Open

Fix bench subproject and make sure it builds correctly in CI. #695

busti opened this issue Feb 22, 2023 · 2 comments

Comments

@busti
Copy link
Collaborator

busti commented Feb 22, 2023

Running the bench subproject currently results in node-gyp throwing errors because it's version went out of sync with nodejs.
This error is only caught when running the subproject and not when compiling.

We should probably also run the benchmarks on every PR and somehow show them inside the Pull Request so that any changes don't worsen the performance of the project.

@fdietze
Copy link
Member

fdietze commented Feb 28, 2023

The problem with those benchmarks is that they are running with jsdom and not in a browser. So the results don't have any value right now.

@busti
Copy link
Collaborator Author

busti commented Feb 28, 2023

Maybe we should run them using something like cypress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants