Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Sink and Observable by importing outwatch.dom._ #82

Closed
fdietze opened this issue Nov 7, 2017 · 1 comment
Closed

Import Sink and Observable by importing outwatch.dom._ #82

fdietze opened this issue Nov 7, 2017 · 1 comment

Comments

@fdietze
Copy link
Member

fdietze commented Nov 7, 2017

@mariusmuja wrote:

I like the idea of having Observable and Sink imported by outwatch.dom._. We could do something like this:

 package object dom extends Attributes with Tags with Handlers {
 
+  type Observable[+A] = rxscalajs.Observable[A]
+  val Observable = rxscalajs.Observable
+
+  type Sink[-A] = outwatch.Sink[A]
+  val Sink = outwatch.Sink
+
   type VNode = IO[VNode_]
   type VDomModifier = IO[VDomModifier_]

An additional benefit is that it would ease porting Outwatch to another reactive streams library such as Monix. I prefer Monix to rxjs, I did a port here: https://github.com/mariusmuja/outwatch/tree/referential-transparent-refactor-monix

@fdietze
Copy link
Member Author

fdietze commented Nov 21, 2017

fixed by #91.

@fdietze fdietze closed this as completed Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant