Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT REQUEST] SOCKET - Custom Socket Instances #6

Closed
OvileAmriam opened this issue Jul 29, 2022 · 1 comment
Closed

[ENHANCEMENT REQUEST] SOCKET - Custom Socket Instances #6

OvileAmriam opened this issue Jul 29, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@OvileAmriam
Copy link
Member

Native instances such as socket and client should be safe & shouldn't be exposed on functions like socket.onClientConnect & socket.onClientDisconnect as such. Clients can explicitly control otherwise which is not great.

Consideration:

  • Make a new reference for socket instances (Using custom classes)
  • Whitelist the methods only that client/server should be able to control
@OvileAmriam OvileAmriam added the enhancement New feature or request label Jul 29, 2022
@OvileAmriam
Copy link
Member Author

Implemented & Merged w/ release: https://github.com/ov-studio/vNetworkify/releases/tag/v.2.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OvileAmriam