Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Windows, module resolver does not handle junctions or symlinks correctly #10469

Closed
Jarred-Sumner opened this issue Apr 24, 2024 · 2 comments · Fixed by #11157
Closed

On Windows, module resolver does not handle junctions or symlinks correctly #10469

Jarred-Sumner opened this issue Apr 24, 2024 · 2 comments · Fixed by #11157
Assignees
Labels
node.js Compatibility with Node.js APIs windows An issue that only occurs on Windows

Comments

@Jarred-Sumner
Copy link
Collaborator

Jarred-Sumner commented Apr 24, 2024

On Windows, Bun's module resolver does not detect correctly that a junction is a directory. We think it is a file. We try to read it from a file. And the code for reading files doesn't expect to receive a directory, causing it to return Unexpected.

Related issues:

@Jarred-Sumner Jarred-Sumner added node.js Compatibility with Node.js APIs windows An issue that only occurs on Windows labels Apr 24, 2024
@aspectiscool
Copy link

Can we please prioritize this? Monorepos basically just don't work at all on Windows.

@paperdave
Copy link
Collaborator

interesting

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node.js Compatibility with Node.js APIs windows An issue that only occurs on Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants