Compat with node:net server.listen(port, host, backlog, callback)?

[ignoramous]

What version of Bun is running?

0.8.1+16b4bf341acc0f4804f0b6bdf5298c180cd00366

What platform is your computer?

Linux 5.4.0-135-generic x86_64 x86_64

What steps can reproduce the bug?

Listening with server.listen(port, host, backlog, callback) (like we do) does not work when the package is bundled up with bun build --target node. Removing backlog however works.

Also I've noticed that, bun run <entry-point> works as-is (with the backlog arg) but bun build <entry-point> --target node doesn't.

What is the expected behavior?

Do not expect bun bundle <nodejs-entry-point> --target node to behave any differently to bun run <nodejs-entry-point>

What do you see instead?

The Bun process continues executing the rest of the code without reporting any error.

Additional information

Coincidentally, I see the same "bug" (?) with Deno, too.

[elmpp]

+1

See the following error:

489 |   listen(port, hostname, onListen) {
                   ^
TypeError: The argument 'options' must have the property "port" or "path". Received {"port":"2222","host":"127.0.0.1"}

With the following client code:

)).listen({
    port: process.env.GIT_SSH_MOCK_SERVER_PORT || 2222,
    host: '127.0.0.1',
    debug: console.log,
  }, function () {
    console.log('Listening on port ' + this.address().port)
  })

---

ETA, may be related to my specifying the port as a string. ParseInt() yields different behaviour

[tteggel]

I've hit this in Socket.connect() today. Seems like bad things happen when you pass port as a string e.g. from the env. Node will happily coerce string to number.

[nektro]

Does this still reproduce for you?

[tteggel]

This works as expected for me now, thanks 👍