Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw more descriptive error when trying to serialize Livepack itself #134

Open
overlookmotel opened this issue Mar 1, 2021 · 1 comment
Labels
enhancement Improvements

Comments

@overlookmotel
Copy link
Owner

Trying to serialize Livepack's own internals throws error Function was not tracked.

e.g. serialize( serialize )

It would be better if Livepack recognised it's own internals and threw a more descriptive error Cannot serialize Livepack's internals.

The above case is silly. But it could happen accidentally if:

  1. A function contains eval() and Livepack is in scope.
  2. A class contains methods some of which are meant to run at build time, and some at runtime. The build-time methods might access Livepack.
  3. Incorrect use of defer(), once that's implemented (Allow deferring import and evaluation to runtime #131).
@overlookmotel overlookmotel added the enhancement Improvements label Mar 1, 2021
@overlookmotel
Copy link
Owner Author

See also #97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements
Projects
None yet
Development

No branches or pull requests

1 participant