Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal script proxies that were are sometimes not destroyed together with script engine: #1034

Open
ksuprynowicz opened this issue Jun 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ksuprynowicz
Copy link
Member

__pthread_kill_implementation 0x00007ffff04a816c
ScriptSignalV8Proxy::~ScriptSignalV8Proxy ScriptObjectV8Proxy.cpp:1220
ScriptSignalV8Proxy::~ScriptSignalV8Proxy ScriptObjectV8Proxy.cpp:1225
Application::notify Application.cpp:4292
@ksuprynowicz ksuprynowicz added the bug Something isn't working label Jun 17, 2024
@ksuprynowicz
Copy link
Member Author

Sometimes script signal proxies do not get deleted with script engine since there's some remaining reference to their smart pointer. Then later when they get deleted script engine is already gone and access-after-delete happens, sometimes causing crash.
To fix this we should try adding a check in script engine destructor that would assure that all the proxies are deleted. This could be accomplished with weak smart pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant