Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magit #24

Closed
rothmichaels opened this issue Sep 3, 2012 · 1 comment
Closed

magit #24

rothmichaels opened this issue Sep 3, 2012 · 1 comment

Comments

@rothmichaels
Copy link
Contributor

I see you have some color theme and other configuration for magit, but there is no magit with your distribution.

I made a new pack (git-pack) that right now just includes magit. Are you interested in a pull request for this pack? (I have it setup as a dev pack with a submodule like your other dev packs).

I didn't send the pull request directly because like my js2-mode pull request, I'm not sure if you wanted to include these modes in your distribution since I saw some config for them but not the modes themselves (at first I thought you were avoiding GPL, but i saw some other GPL stuff included in your distribution).

Anyway, the git-pack I made seems to be working fine, so let me know if you want a pull request.

@samaaron
Copy link
Member

samaaron commented Sep 4, 2012

Hey there,

I scanned through your js2-mode pull request, but couldn't get a quick understanding of the implications, so put it on the TODO list to look at with more detail when I get some spare brain cycles.

A separate magit pack would be very interesting to include, so please go ahead with a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants