lastVersion and latestVersion should return the latest and not the first

[4unkur]

The docs are misleading. When I call:

$model->lastVersion;

I am expecting to get the latest version but I get the first. I see in the sources that it returns latest() relationship, so to get the latest version I have to use:

$model->lastVersion()->first();

In this case I get what I expect.
Suggestion: Edit the docs or update the code

[overtrue]

Plz, paste your code, because they are same result in laravel:

$model->lastVersion;
$model->lastVersion()->first();

[4unkur]

@overtrue I have rechecked and found that issue was due to the missing $model->refresh() call.

Here's the failing test:

    public function it_returns_latest_version()
    {
        $post = Post::create(['title' => 'version1', 'content' => 'version1 content']);
        $firstVersion = $post->lastVersion;

        $post->update(['title' => 'version2']);
        $post->update(['title' => 'version3']);
        $post->update(['title' => 'version4']);

        $this->assertEquals(
            $post->latestVersion()->first()->id,
            $post->lastVersion->id
        );

        $this->assertNotEquals(
            $firstVersion->id,
            $post->lastVersion->id,
        );
    }

The second assertion is failing. In order to fix: $post->refresh() should be executed.
My bad.

Thanks.

[overtrue]

Yes, because relations were cached.