Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSObserver does not display final render time #786

Closed
HTL2001 opened this issue Aug 16, 2012 · 2 comments
Closed

JSObserver does not display final render time #786

HTL2001 opened this issue Aug 16, 2012 · 2 comments

Comments

@HTL2001
Copy link

HTL2001 commented Aug 16, 2012

progress.json contains:
{"messageTime": 1345143759.024339, "message": "", "update": 5000}
after a finished render. I did not specify custom messages

@mindlesstux
Copy link

Not sure why you got a blank message in the JSON. Mine had a update of -1 and would hide the little progress window that would show the time it took.

Looking at the code it my issue was a simple fix.

https://github.com/bdavenport/Minecraft-Overviewer/commit/af2412dbd148c22576af32aeac1a6ee085169430

If you update grab the latest copy of Minecraft-Overviewer are you still having your problem?

@pironic
Copy link
Member

pironic commented Jan 23, 2013

Im going to close this feature request as it pertains to JSObserver. We have not merged any JSObserver code into master, or any other Overviewer branch yet. As such all discussions regarding this feature are going to be considered an addon for now. I have opened an issue on the addons repo that can be accessed by clicking on the link to it, located directly above this comment. Please use that issue to continue discussion on the JSObserver.

Thank you for contacting the Overviewer Development Team.

@pironic pironic closed this as completed Jan 23, 2013
@eminence eminence reopened this Jan 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants