Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handlers/Composers structure Templating (ProtoBuf) #144

Open
2 tasks
BurakDev opened this issue Sep 19, 2016 · 9 comments
Open
2 tasks

Handlers/Composers structure Templating (ProtoBuf) #144

BurakDev opened this issue Sep 19, 2016 · 9 comments

Comments

@BurakDev
Copy link
Collaborator

BurakDev commented Sep 19, 2016

This issue is open to debate and talk about a templating system for packets structures.

This feature will allow emulator to support easily multiple releases (and structures changes).

List of ideas :

  • Using homemade templating (RELEASE63-XXXXXXXX-XXXX/Handlers/*Event.model)
  • Using ProtoBuf (support Habbo binary protocol natively)
@BurakDev BurakDev added this to the Development Stage milestone Sep 19, 2016
@ovflowd
Copy link
Owner

ovflowd commented Sep 19, 2016

Will be only for Incoming or Outgoing Packets? If for those two, need be *Composer, *Event

@BurakDev
Copy link
Collaborator Author

Incoming and Outgoing, Incoming to automaticly parsing and checking all packet in one step and Outgoing to automaticly build packet with all needed data.

@ovflowd
Copy link
Owner

ovflowd commented Sep 19, 2016

Write in the Issue Description information about Protobuf, please.

@ovflowd
Copy link
Owner

ovflowd commented Sep 20, 2016

That's important if we move to new crypto @BurakDev @TheDoct0r11 @ZakAmirz @nenji

@ovflowd ovflowd changed the title Handlers/Composers structure Templating Handlers/Composers structure Templating (ProtoBuf) Sep 20, 2016
@TheDoct0r11
Copy link
Collaborator

ProtoBuf is a cool tool, but sadly useless for our requirements:
https://developers.google.com/protocol-buffers/docs/encoding

@ovflowd
Copy link
Owner

ovflowd commented Sep 20, 2016

O don't think is useless.
@BurakDev what you think?

@TheDoct0r11
Copy link
Collaborator

@Sant0ro It just won't work. Look at the link I've posted. The encoding isn't compatible with the client.

@ovflowd
Copy link
Owner

ovflowd commented Sep 20, 2016

We just can't encode in our way?

@TheDoct0r11
Copy link
Collaborator

From what I've read I don't think so. The library is designed to detect different message versions, but it does this per message, not per client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants