fix(worker): overwrite value each time (#4903)

ovh · Jan 20, 2020 · 1bf3c5d · 1bf3c5d
1 parent dab0aa8
commit 1bf3c5d
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/engine/worker/internal/run.go b/engine/worker/internal/run.go
@@ -126,8 +126,11 @@ func (w *CurrentWorker) runJob(ctx context.Context, a *sdk.Action, jobID int64,
 			// Check if all newVariables are in currentJob.params
 			// variable can be add in w.currentJob.newVariables by worker command export
 			for _, newVariableFromHandler := range w.currentJob.newVariables {
-				if sdk.ParameterFind(w.currentJob.params, newVariableFromHandler.Name) == nil {
+				p := sdk.ParameterFind(w.currentJob.params, newVariableFromHandler.Name)
+				if p == nil {
 					w.currentJob.params = append(w.currentJob.params, newVariableFromHandler.ToParameter(""))
+				} else {
+					p.Value = newVariableFromHandler.Value
 				}
 			}
 
@@ -270,8 +273,11 @@ func (w *CurrentWorker) runSteps(ctx context.Context, steps []sdk.Action, a sdk.
 		// Check if all newVariables are in currentJob.params
 		// variable can be add in w.currentJob.newVariables by worker command export
 		for _, newVariableFromHandler := range w.currentJob.newVariables {
-			if sdk.ParameterFind(w.currentJob.params, newVariableFromHandler.Name) == nil {
+			p := sdk.ParameterFind(w.currentJob.params, newVariableFromHandler.Name)
+			if p == nil {
 				w.currentJob.params = append(w.currentJob.params, newVariableFromHandler.ToParameter(""))
+			} else {
+				p.Value = newVariableFromHandler.Value
 			}
 		}