Skip to content

Commit

Permalink
fix(api): execute outgoing hook even if it is not success (#4814)
Browse files Browse the repository at this point in the history
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
  • Loading branch information
bnjjj committed Dec 12, 2019
1 parent 4318f8d commit 82e53ad
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions engine/api/workflow/process_outgoinghook.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,6 @@ func processNodeOutGoingHook(ctx context.Context, db gorp.SqlExecutor, store cac
}
}

//FIX: For the moment, we trigger outgoing hooks on success
for _, p := range parentNodeRun {
if p.Status != sdk.StatusSuccess.String() {
return report, false, nil
}
}

srvs, err := services.FindByType(db, services.TypeHooks)
if err != nil {
return nil, false, sdk.WrapError(err, "Cannot get hooks service")
Expand Down

0 comments on commit 82e53ad

Please sign in to comment.