fix(api): fix stop workflow run for purge, do not stop all nodes (#3223)

Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
ovh · Aug 20, 2018 · cf2a7f7 · cf2a7f7
1 parent 96d1524
commit cf2a7f7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/engine/api/workflow/dao_run.go b/engine/api/workflow/dao_run.go
@@ -828,8 +828,10 @@ func stopRunsBlocked(db *gorp.DbMap) error {
 		}
 
 		stopWorkflowNodeRunStages(&nr)
-		nr.Status = sdk.StatusStopped.String()
-		nr.Done = now
+		if !sdk.StatusIsTerminated(resp[i].Status) {
+			nr.Status = sdk.StatusStopped.String()
+			nr.Done = now
+		}
 
 		if err := updateNodeRunStatusAndStage(tx, &nr); err != nil {
 			return sdk.WrapError(err, "stopRunsBlocked> cannot update node runs stages")

diff --git a/engine/api/workflow/process.go b/engine/api/workflow/process.go
@@ -653,6 +653,7 @@ func processWorkflowNodeRun(ctx context.Context, db gorp.SqlExecutor, store cach
 	if err := insertWorkflowNodeRun(db, run); err != nil {
 		return report, true, sdk.WrapError(err, "processWorkflowNodeRun> unable to insert run (node id : %d, node name : %s, subnumber : %d)", run.WorkflowNodeID, run.WorkflowNodeName, run.SubNumber)
 	}
+	w.LastExecution = time.Now()
 
 	buildParameters := sdk.ParametersToMap(run.BuildParameters)
 	_, okUI := buildParameters["cds.ui.pipeline.run"]