feat(sdk): new httpSSEClient (#3434)

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>

sdk/cdsclient/client.go

@@ -12,13 +12,14 @@ import (
 )
 
 type client struct {
-	isWorker   bool
-	isService  bool
-	isProvider bool
-	HTTPClient HTTPClient
-	config     Config
-	name       string
-	service    *sdk.Service
+	isWorker      bool
+	isService     bool
+	isProvider    bool
+	HTTPClient    HTTPClient
+	HTTPSSEClient HTTPClient
+	config        Config
+	name          string
+	service       *sdk.Service
 }
 
 // NewHTTPClient returns a new HTTP Client
@@ -46,6 +47,7 @@ func New(c Config) Interface {
 	cli := new(client)
 	cli.config = c
 	cli.HTTPClient = NewHTTPClient(time.Second*60, c.InsecureSkipVerifyTLS)
+	cli.HTTPSSEClient = NewHTTPClient(0, c.InsecureSkipVerifyTLS)
 	cli.init()
 	return cli
 }
@@ -60,6 +62,7 @@ func NewService(endpoint string, timeout time.Duration, insecureSkipVerifyTLS bo
 	cli := new(client)
 	cli.config = conf
 	cli.HTTPClient = NewHTTPClient(timeout, conf.InsecureSkipVerifyTLS)
+	cli.HTTPSSEClient = NewHTTPClient(0, conf.InsecureSkipVerifyTLS)
 	cli.isService = true
 	cli.init()
 	return cli
@@ -79,6 +82,7 @@ func NewWorker(endpoint string, name string, c HTTPClient) Interface {
 	} else {
 		cli.HTTPClient = c
 	}
+	cli.HTTPSSEClient = NewHTTPClient(0, false)
 
 	cli.isWorker = true
 	cli.name = name
@@ -112,6 +116,7 @@ func NewProviderClient(cfg ProviderConfig) ProviderClient {
 	cli := new(client)
 	cli.config = conf
 	cli.HTTPClient = NewHTTPClient(time.Duration(cfg.RequestSecondsTimeout)*time.Second, conf.InsecureSkipVerifyTLS)
+	cli.HTTPSSEClient = NewHTTPClient(0, conf.InsecureSkipVerifyTLS)
 	cli.isProvider = true
 	cli.name = cfg.Name
 	cli.init()

sdk/cdsclient/http.go

@@ -49,11 +49,6 @@ type HTTPClient interface {
 	Do(*http.Request) (*http.Response, error)
 }
 
-// NoTimeout returns a http.DefaultClient from a HTTPClient
-func NoTimeout(c HTTPClient) HTTPClient {
-	return http.DefaultClient
-}
-
 // SetHeader modify headers of http.Request
 func SetHeader(key, value string) RequestModifier {
 	return func(req *http.Request) {
@@ -243,7 +238,7 @@ func (c *client) Stream(ctx context.Context, method string, path string, body io
 		var errDo error
 		var resp *http.Response
 		if noTimeout {
-			resp, errDo = NoTimeout(c.HTTPClient).Do(req)
+			resp, errDo = c.HTTPSSEClient.Do(req)
 		} else {
 			resp, errDo = c.HTTPClient.Do(req)
 		}
@@ -334,7 +329,7 @@ func (c *client) UploadMultiPart(method string, path string, body *bytes.Buffer,
 		}
 	}
 
-	resp, err := NoTimeout(c.HTTPClient).Do(req)
+	resp, err := c.HTTPSSEClient.Do(req)
 	if err != nil {
 		return nil, 0, err
 	}

sdk/cdsclient/http_sse.go

@@ -64,7 +64,7 @@ func (c *client) RequestSSEGet(ctx context.Context, path string, evCh chan<- SSE
 		req.SetBasicAuth(c.config.User, c.config.Token)
 	}
 
-	resp, err := NoTimeout(c.HTTPClient).Do(req)
+	resp, err := c.HTTPSSEClient.Do(req)
 	if err != nil {
 		return err
 	}