fix(api): fix retro migrate, set node context from workflow maps (#3600)

ovh · Nov 15, 2018 · d9d8695 · d9d8695
1 parent fbee444
commit d9d8695
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 2 deletions.
diff --git a/sdk/workflow.go b/sdk/workflow.go
@@ -72,6 +72,33 @@ func (w *Workflow) RetroMigrate() {
 			w.Joins = append(w.Joins, j.retroMigrateJoin())
 		}
 	}
+
+	// Set context on old node
+	for _, n := range w.Nodes(true) {
+		node := w.GetNode(n.ID)
+		if node.Context == nil {
+			continue
+		}
+
+		if node.Context.ApplicationID != 0 {
+			app, ok := w.Applications[node.Context.ApplicationID]
+			if ok {
+				node.Context.Application = &app
+			}
+		}
+		if node.Context.EnvironmentID != 0 {
+			env, ok := w.Environments[node.Context.EnvironmentID]
+			if ok {
+				node.Context.Environment = &env
+			}
+		}
+		if node.Context.ProjectPlatformID != 0 {
+			pp, ok := w.ProjectPlatforms[node.Context.ProjectPlatformID]
+			if ok {
+				node.Context.ProjectPlatform = &pp
+			}
+		}
+	}
 }
 
 // Migrate old workflow struct into new workflow struct

diff --git a/ui/src/app/shared/workflow/wnode/wnode.component.ts b/ui/src/app/shared/workflow/wnode/wnode.component.ts
@@ -103,7 +103,8 @@ export class WorkflowWNodeComponent implements OnInit {
                 if (this._workflowEventStore.isRunSelected() && this.currentNodeRun) {
                     this._router.navigate([
                         'node', this.currentNodeRun.id
-                    ], {relativeTo: this._activatedRoute, queryParams: {name: this.node.name}});
+                    ], {relativeTo: this._activatedRoute, queryParams: {name: this.node.name,
+                            node_id: this.node.id, node_ref: this.node.ref}});
                 } else {
                     this._router.navigate([
                         '/project', this.project.key,

diff --git a/ui/src/app/views/workflow/run/node/workflow.run.node.component.ts b/ui/src/app/views/workflow/run/node/workflow.run.node.component.ts
@@ -75,7 +75,7 @@ export class WorkflowNodeRunComponent {
         this._activatedRoute.params.subscribe(params => {
             this.nodeRun = null;
             let number = params['number'];
-            let nodeRunId = params['node_id'];
+            let nodeRunId = params['nodeId'];
 
             if (this.project && this.project.key && this.workflowName && number && nodeRunId) {
                 // Get workflow Run