feat: add external service #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci
reviewed
Jul 23, 2018
engine/main.go
Outdated
| @@ -141,6 +141,7 @@ Comming soon...`, | |||
| conf.API.Auth.SharedInfraToken = sdk.RandomString(128) | |||
| conf.API.Secrets.Key = sdk.RandomString(32) | |||
| conf.API.Providers = append(conf.API.Providers, api.ProviderConfiguration{"sample-provider", sdk.RandomString(32)}) | |||
| conf.API.Services = append(conf.API.Services, api.ServiceConfiguration{"sample-service", "https://ovh.github.io", 443, "/cds", 443, "doc"}) | |||
There was a problem hiding this comment.
github.com/ovh/cds/engine/api.ServiceConfiguration composite literal uses unkeyed fields
fsamin
requested changes
Jul 23, 2018
engine/api/api.go
Outdated
| if err := services.InitExternal(a.mustDB, a.Cache, externalServices); err != nil { | ||
| return fmt.Errorf("unable to init external service: %v", err) | ||
| } | ||
| go services.Pings(ctx, a.mustDB, externalServices) |
golangci
reviewed
Jul 23, 2018
engine/api/ascode_test.go
Outdated
| mockService := &sdk.Service{Name: "Test_postImportAsCodeHandler", Type: services.TypeRepositories} | ||
| repositoryService.Delete(mockService) | ||
| test.NoError(t, repositoryService.Insert(mockService)) | ||
| services.Delete(api.mustDB(), mockService) |
There was a problem hiding this comment.
Error return value of services.Delete is not checked
engine/api/ascode_test.go
Outdated
| mockService := &sdk.Service{Name: "Test_getImportAsCodeHandler", Type: services.TypeRepositories} | ||
| repositoryService.Delete(mockService) | ||
| test.NoError(t, repositoryService.Insert(mockService)) | ||
| services.Delete(db, mockService) |
There was a problem hiding this comment.
Error return value of services.Delete is not checked
engine/api/ascode_test.go
Outdated
| mockService := &sdk.Service{Name: "Test_postPerformImportAsCodeHandler_Repo", Type: services.TypeRepositories} | ||
| repositoryService.Delete(mockService) | ||
| test.NoError(t, repositoryService.Insert(mockService)) | ||
| services.Delete(db, mockService) |
There was a problem hiding this comment.
Error return value of services.Delete is not checked
engine/api/services.go
Outdated
| return sdk.WrapError(err, "postServiceRegisterHandler") | ||
| } | ||
| defer tx.Rollback() |
There was a problem hiding this comment.
Error return value of tx.Rollback is not checked
engine/api/services.go
Outdated
| log.Error("serviceAPIHeartbeat> error on repo.Begin:%v", err) | ||
| return | ||
| } | ||
| defer tx.Rollback() |
There was a problem hiding this comment.
Error return value of tx.Rollback is not checked
bnjjj
approved these changes
Jul 23, 2018
golangci
reviewed
Jul 23, 2018
|
|
||
| mockService = &sdk.Service{Name: "Test_postPerformImportAsCodeHandler_VCS", Type: services.TypeHooks} | ||
| repositoryService.Delete(mockService) | ||
| test.NoError(t, repositoryService.Insert(mockService)) | ||
| services.Delete(db, mockService) |
There was a problem hiding this comment.
Error return value of services.Delete is not checked
golangci
reviewed
Jul 23, 2018
| mockService := &sdk.Service{Name: "service_test", Type: "hooks"} | ||
| repositoryService.Delete(mockService) | ||
| test.NoError(t, repositoryService.Insert(mockService)) | ||
| services.Delete(db, mockService) |
There was a problem hiding this comment.
Error return value of services.Delete is not checked
fsamin
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ovh/cds