Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api,worker): add default value to tag parameter in gitClone #3227

Merged
merged 4 commits into from Aug 22, 2018

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Aug 20, 2018

Signed-off-by: Benjamin Coenen benjamin.coenen@corp.ovh.com

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@bnjjj bnjjj added the feature label Aug 20, 2018
@bnjjj bnjjj requested a review from yesnault August 20, 2018 13:15
@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 20, 2018

CDS Report it#5636.0 ✘

  • w-it

    • w-it ✘
      Unit Tests Report
  • Platform model admin [tests/cli_admin_platform_model.yml]

  • Application Command TestSuite [tests/cli_application.yml]

  • Environment Command TestSuite [tests/cli_environment.yml]

  • Pipeline Command TestSuite [tests/cli_pipeline.yml]

  • Pipeline Export / Import Command TestSuite [tests/cli_pipeline_export_import.yml]

  • Action Command TestSuite with cdsctl [tests/clictl_action.yml]

  • Broadcast Command TestSuite [tests/clictl_admin_broadcast.yml]

  • Plugins Command TestSuite with cdsctl [tests/clictl_admin_plugin_and_platforms.yml]

  • Action Command TestSuite with cdsctl [tests/clictl_admin_services.yml]

  • Application Command TestSuite with CDS ctl [tests/clictl_application.yml]

  • Environement Command TestSuite with CDS ctl [tests/clictl_environment.yml]

  • Group Command TestSuite [tests/clictl_group.yml]

  • Pipeline Command TestSuite with CDS ctl [tests/clictl_pipeline.yml]

  • Project Command TestSuite with CDS ctl [tests/clictl_project.yml]

  • Token Command TestSuite with CDS ctl [tests/clictl_token.yml]

  • User Command TestSuite [tests/clictl_user.yml]

  • Version Command TestSuite [tests/clictl_version.yml]

  • Worker Command TestSuite [tests/clictl_worker_model.yml]

  • Create a simple workflow (ITSCWRKFLW3) and run it [tests/sc_workflow_create_run_join.yml]

  • Create a simple workflow (ITSCWRKFLW1) and pull it [tests/sc_workflow_create_simple.yml]

  • Create a simple workflow (ITSCWRKFLW6) and run it to test gitClone action [tests/sc_workflow_git_clone_tag.yml]

  • Workflow (ITSCWRKFLW5) should use the worker key install command [tests/sc_workflow_key_install.yml]

  • Workflow (ITSCWRKFLW4) should use the worker cache command [tests/sc_workflow_run_cache.yml]

    • the workflow should be successfull ✘
  • Create a simple workflow (ITSCWRKFLW2) and run it [tests/sc_workflow_run_simple.yml]

  • Create a simple workflow (ITSCWRKFLW2) run it and then stop it [tests/sc_workflow_stop_simple.yml]

  • Create a simple workflow (ITSCWRKFLW2), update it and run it [tests/sc_workflow_update_run.yml]

Copy link
Member

@yesnault yesnault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the clictl_action.yml should be completed to check the default value of git.tag

if tag != "" && tag != sdk.DefaultGitCloneParameterTagValue {
sendLog(fmt.Sprintf("git.tag: %s", tag))
} else {
if (branch == "" || branch == "{{.git.branch}}") && tag == "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tag should not be checked here.

if (branch == "" || branch == "{{.git.branch}}") && tag == "" {

should be:

if (branch == "" || branch == "{{.git.branch}}") && tag == "" {

no?

Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
Copy link
Member

@yesnault yesnault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the clictl_action.yml should be completed to check the default value of git.tag

Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@bnjjj
Copy link
Contributor Author

bnjjj commented Aug 22, 2018

done @yesnault

@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 22, 2018

CDS Report it#5668.1 ✘

  • w-it

    • w-it ✘
      Unit Tests Report
  • Platform model admin [tests/cli_admin_platform_model.yml]

  • Application Command TestSuite [tests/cli_application.yml]

  • Environment Command TestSuite [tests/cli_environment.yml]

  • Pipeline Command TestSuite [tests/cli_pipeline.yml]

  • Pipeline Export / Import Command TestSuite [tests/cli_pipeline_export_import.yml]

  • Action Command TestSuite with cdsctl [tests/clictl_action.yml]

  • Broadcast Command TestSuite [tests/clictl_admin_broadcast.yml]

  • Plugins Command TestSuite with cdsctl [tests/clictl_admin_plugin_and_platforms.yml]

  • Action Command TestSuite with cdsctl [tests/clictl_admin_services.yml]

  • Application Command TestSuite with CDS ctl [tests/clictl_application.yml]

  • Environement Command TestSuite with CDS ctl [tests/clictl_environment.yml]

  • Group Command TestSuite [tests/clictl_group.yml]

  • Pipeline Command TestSuite with CDS ctl [tests/clictl_pipeline.yml]

  • Project Command TestSuite with CDS ctl [tests/clictl_project.yml]

  • Token Command TestSuite with CDS ctl [tests/clictl_token.yml]

  • User Command TestSuite [tests/clictl_user.yml]

  • Version Command TestSuite [tests/clictl_version.yml]

  • Worker Command TestSuite [tests/clictl_worker_model.yml]

  • Create a simple workflow (ITSCWRKFLW3) and run it [tests/sc_workflow_create_run_join.yml]

  • Create a simple workflow (ITSCWRKFLW1) and pull it [tests/sc_workflow_create_simple.yml]

  • Create a simple workflow (ITSCWRKFLW6) and run it to test gitClone action [tests/sc_workflow_git_clone_tag.yml]

  • Workflow (ITSCWRKFLW5) should use the worker key install command [tests/sc_workflow_key_install.yml]

    • the workflow should be successfull ✘
  • Workflow (ITSCWRKFLW4) should use the worker cache command [tests/sc_workflow_run_cache.yml]

  • Create a simple workflow (ITSCWRKFLW2) and run it [tests/sc_workflow_run_simple.yml]

  • Create a simple workflow (ITSCWRKFLW2) run it and then stop it [tests/sc_workflow_stop_simple.yml]

  • Create a simple workflow (ITSCWRKFLW2), update it and run it [tests/sc_workflow_update_run.yml]

@bnjjj bnjjj merged commit 34edf19 into master Aug 22, 2018
@bnjjj bnjjj deleted the fix_default_git_tag_value branch October 10, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants