New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api,worker): add default value to tag parameter in gitClone #3227
Conversation
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
CDS Report it#5636.0 ✘
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the clictl_action.yml should be completed to check the default value of git.tag
engine/worker/builtin_gitclone.go
Outdated
if tag != "" && tag != sdk.DefaultGitCloneParameterTagValue { | ||
sendLog(fmt.Sprintf("git.tag: %s", tag)) | ||
} else { | ||
if (branch == "" || branch == "{{.git.branch}}") && tag == "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tag should not be checked here.
if (branch == "" || branch == "{{.git.branch}}") && tag == "" {
should be:
if (branch == "" || branch == "{{.git.branch}}") && tag == "" {
no?
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the clictl_action.yml should be completed to check the default value of git.tag
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
done @yesnault |
CDS Report it#5668.1 ✘
|
Signed-off-by: Benjamin Coenen benjamin.coenen@corp.ovh.com
@ovh/cds