feat(api): add grpc plugin action handlers #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
bnjjj
requested review from
fsamin,
richardlt,
sguiheux and
yesnault
as code owners
golangcibot
reviewed
Sep 10, 2018
| fmt.Printf("Error writing content to file: %s\n", errw.Error()) | ||
| return "", errw | ||
| } | ||
| outfile.Sync() |
There was a problem hiding this comment.
Error return value of outfile.Sync is not checked
engine/api/grpc_plugin.go
Outdated
| if err != nil { | ||
| return sdk.WrapError(err, "postPGRPCluginHandler> Cannot start transaction") | ||
| } | ||
| defer tx.Rollback() |
There was a problem hiding this comment.
Error return value of tx.Rollback is not checked
engine/api/grpc_plugin.go
Outdated
| if err != nil { | ||
| return sdk.WrapError(err, "putGRPCluginHandler> Cannot start transaction") | ||
| } | ||
| defer tx.Rollback() |
There was a problem hiding this comment.
Error return value of tx.Rollback is not checked
|
|
||
| type Common struct { | ||
| grpcplugin.Common | ||
| conn *grpc.ClientConn |
| import "strings" | ||
|
|
||
| //Escape characters | ||
| func Escape(s string) string { |
| } | ||
|
|
||
| // parseTemplateParameters parses a list of key value pairs separated by new lines | ||
| func parseTemplateParameters(s string) (map[string]interface{}, error) { |
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
richardlt
reviewed
Sep 10, 2018
sdk/grpcplugin/grpcplugin.go
Outdated
| @@ -51,7 +51,7 @@ func (c *Common) Start(ctx context.Context) error { | |||
| func (c *Common) start(ctx context.Context, desc *grpc.ServiceDesc, srv interface{}) (Plugin, error) { | |||
| //Start the grpc server on unix socket | |||
| uuid := sdk.UUID() | |||
| c.Socket = filepath.Join(".", "grpcplugin-socket-"+uuid+".sock") | |||
| c.Socket = filepath.Join(os.TempDir(), "grpcplugin-socket-"+uuid+".sock") | |||
sdk/cdsclient/interface.go
Outdated
| PluginGetBinary(string, string, string, io.Writer) error | ||
| PluginDeleteBinary(name string, os string, arch string) error | ||
| PluginGetBinary(name string, os string, arch string, w io.Writer) error | ||
| PluginGetBinaryInfos(name string, os string, arch string) (*sdk.GRPCPluginBinary, error) |
| grpc.WithDialer(func(address string, timeout time.Duration) (net.Conn, error) { | ||
| return net.DialTimeout("unix", socket, timeout) | ||
| }, | ||
| ), |
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
fsamin
approved these changes
Sep 10, 2018
yesnault
approved these changes
Sep 11, 2018
richardlt
approved these changes
Sep 11, 2018
sguiheux
requested changes
Sep 11, 2018
| alters map[string]VariableAlteration | ||
| } | ||
|
|
||
| type VariableAlteration func(interface{}) (interface{}, error) |
|
|
||
| type VariableAlteration func(interface{}) (interface{}, error) | ||
|
|
||
| func NewApplications(file string) (*Applications, error) { |
| } | ||
|
|
||
| buf := new(bytes.Buffer) | ||
| err = tmpl.Execute(buf, variables) |
| "time" | ||
|
|
||
| "github.com/ovh/cds/sdk/grpcplugin" | ||
| "google.golang.org/grpc" |
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
|
CDS Report ut-engine#102.0 ✘
|
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
|
CDS Report build#103.0 ✘
|
sguiheux
approved these changes
Sep 11, 2018
bnjjj
added a commit
that referenced
this pull request
Sep 13, 2018
This was referenced Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUST THE API PART, next one will be the worker part
@ovh/cds