fix(worker): work with booked job #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesnault
requested review from
bnjjj,
fsamin,
richardlt and
sguiheux
as code owners
don't allow worker to work on another job if it was created to work on one specified job this will fix a bunch of issue on worker using pre-requisite service & model options Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
richardlt
approved these changes
Oct 3, 2018
|
do not merge yet, need some rework |
|
rework done |
fsamin
requested changes
Oct 4, 2018
| return true, sdk.WrapError(err, "takeWorkflowJob> Unable to take workflow node run job. This worker can work on another job.") | ||
| if w.bookedWJobID == job.ID { | ||
| return false, sdk.WrapError(err, "takeWorkflowJob> Unable to take workflow node run job. This worker can't work on another job.") | ||
| } else { |
fsamin
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't allow worker to work on another job if it was created to work on one specified job
this will fix a bunch of issue on worker using pre-requisite service & model options
Signed-off-by: Yvonnick Esnault yvonnick.esnault@corp.ovh.com