Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): remove sidebar for node edit and hook edit #4232

Merged
merged 44 commits into from May 20, 2019
Merged

feat(ui): remove sidebar for node edit and hook edit #4232

merged 44 commits into from May 20, 2019

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 29, 2019

CDS Report build-ui#9343.0 ✘

  • Compile
    • Build UI ✘
    • TU All -
    • TU model ✘
    • TU service ✔
    • TU shared ✘
    • TU store ✘
    • TU views ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 30, 2019

CDS Report build-ui#9348.0 ✘

  • Compile
    • Build UI ✘
    • TU All -
    • TU model ✘
    • TU service ✔
    • TU shared ✘
    • TU store ✘
    • TU views ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 3, 2019

CDS Report build-ui#9406.0 ✘

  • Compile
    • Build UI ✘
    • TU All -
    • TU model ✘
    • TU service ✔
    • TU shared ✘
    • TU store ✘
    • TU views ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 3, 2019

CDS Report build-ui#9413.0 ✘

  • Compile
    • Build UI ✘
    • TU All -
    • TU model ✘
    • TU service ✔
    • TU shared ✘
    • TU store ✘
    • TU views ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 7, 2019

CDS Report build-ui#9461.0 ✘

  • Compile
    • Build UI ✘
    • TU All -
    • TU model ✘
    • TU service ✔
    • TU shared ✘
    • TU store ✘
    • TU views ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 13, 2019

CDS Report build-ui#9509.0 ✘

  • Compile
    • Build UI ✔
    • TU All -
    • TU model ✔
    • TU service ✔
    • TU shared ✔
    • TU store ✘
    • TU views ✔

bnjjj
bnjjj suggested changes May 13, 2019
View reviewed changes
engine/api/workflow/dao_run.go Outdated Show resolved Hide resolved
engine/api/workflow/dao_run.go Outdated Show resolved Hide resolved
engine/api/workflow_run.go Outdated Show resolved Hide resolved
richardlt
richardlt reviewed May 14, 2019
View reviewed changes
ui/package.json Outdated Show resolved Hide resolved
yesnault
yesnault requested changes May 14, 2019
View reviewed changes
ui/src/assets/i18n/fr.json Outdated Show resolved Hide resolved
ui/src/assets/i18n/fr.json Outdated Show resolved Hide resolved
@sguiheux @yesnault
Apply suggestions from code review
c292e30 
Co-Authored-By: Yvonnick Esnault <yvonnick@esnau.lt>
yesnault
yesnault requested changes May 15, 2019
View reviewed changes
ui/src/assets/i18n/en.json Outdated Show resolved Hide resolved
@fsamin fsamin added the ui label May 20, 2019
@yesnault yesnault merged commit 8785b9b into master May 20, 2019
@fsamin fsamin deleted the uiNoSideBar branch May 24, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@richardlt richardlt richardlt approved these changes

@bnjjj bnjjj bnjjj approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt @bnjjj