fix(hatchery/swarm): improve some logs #4303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatchery swarm: avoid error log if a container is already under deletion Hatchery ask to disable a worker when "she" can't see the worker alive on her side - with building status on API. In this cas, let hatchery to disable worker even if the worker is building on api side. Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
yesnault
requested review from
bnjjj,
fsamin,
richardlt and
sguiheux
as code owners
yesnault
commented
May 17, 2019
yesnault
changed the title
bnjjj
approved these changes
May 17, 2019
fsamin
approved these changes
May 20, 2019
sguiheux
approved these changes
May 20, 2019
richardlt
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hatchery swarm: avoid error log if a container is already under deletion
Signed-off-by: Yvonnick Esnault yvonnick.esnault@corp.ovh.com