Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api,ui): edit ascode workflow/pipeline in UI #4865

Merged
merged 60 commits into from
Feb 3, 2020
Merged

feat(api,ui): edit ascode workflow/pipeline in UI #4865

merged 60 commits into from
Feb 3, 2020

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Jan 6, 2020

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

golangcibot
golangcibot reviewed Jan 7, 2020
View reviewed changes
engine/api/event/publish_ascode.go Outdated Show resolved Hide resolved
engine/api/ascode/sync/sync.go Outdated Show resolved Hide resolved
@sguiheux sguiheux mentioned this pull request Jan 8, 2020
Closed
@sguiheux sguiheux requested a review from fsamin January 27, 2020 10:12
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 27, 2020

CDS Report build-all-cds#12195.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 30, 2020

CDS Report build-all-cds#12229.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

richardlt
richardlt requested changes Jan 30, 2020
View reviewed changes
engine/api/application.go Outdated Show resolved Hide resolved
engine/api/application.go Outdated Show resolved Hide resolved
engine/api/application.go Outdated Show resolved Hide resolved
engine/api/application_test.go Show resolved Hide resolved
engine/api/ascode.go Outdated Show resolved Hide resolved
engine/api/ascode/ascode_pr.go Outdated Show resolved Hide resolved
engine/api/ascode/dao.go Outdated Show resolved Hide resolved
engine/api/ascode/sync/sync.go Outdated Show resolved Hide resolved
sguiheux and others added 2 commits January 30, 2020 10:35
@sguiheux @richardlt
Apply suggestions from code review
562c34a 
cr

Co-Authored-By: Richard LT <richard.le.terrier@gmail.com>
@sguiheux
fix: code revie
6950d47
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 30, 2020

CDS Report build-all-cds#12234.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 30, 2020

CDS Report build-all-cds#12236.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

sguiheux and others added 2 commits January 30, 2020 13:35
@sguiheux
fix: unit test
9fd0771
@sguiheux @bnjjj
Apply suggestions from code review
5612384 
Co-Authored-By: Coenen Benjamin <benjamin.coenen@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 30, 2020

CDS Report build-all-cds#12241.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@sguiheux sguiheux requested a review from bnjjj January 30, 2020 13:37
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 30, 2020

CDS Report build-all-cds#12243.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@sguiheux sguiheux merged commit 7e47749 into master Feb 3, 2020
@richardlt richardlt deleted the asCodeEditRebased2 branch February 18, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@richardlt richardlt richardlt approved these changes

@bnjjj bnjjj bnjjj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt @bnjjj @golangcibot