Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hooks): avoid to send same gerrit event twice or more #4881

Merged
merged 3 commits into from
Jan 13, 2020
Merged

fix(hooks): avoid to send same gerrit event twice or more #4881

merged 3 commits into from
Jan 13, 2020

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@sguiheux sguiheux changed the base branch from master to hotfix January 13, 2020 07:39
golangcibot
golangcibot reviewed Jan 13, 2020
View reviewed changes
engine/hooks/gerrit.go Outdated

// compute md5
hasher := md5.New()
hasher.Write(lineBytes)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error return value of hasher.Write is not checked (from errcheck)

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 13, 2020

CDS Report build-all-cds#11987.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✘
    • Helm Tests ✔
    • Standalone Tests ✘

@fsamin fsamin merged commit 92d3e51 into hotfix Jan 13, 2020
richardlt pushed a commit that referenced this pull request Jan 13, 2020
@sguiheux @richardlt
fix(hooks): avoid to send same gerrit event twice or more (#4881)
5f22b91
richardlt pushed a commit that referenced this pull request Jan 13, 2020
@sguiheux @richardlt
fix(hooks): avoid to send same gerrit event twice or more (#4881)
bd70519
@richardlt richardlt deleted the hotfix-gerritduplicate branch January 17, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@richardlt richardlt richardlt approved these changes

@bnjjj bnjjj bnjjj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt @bnjjj @golangcibot