Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(worker): path.IsAbs is not working on windows #4901

Merged
merged 1 commit into from
Jan 20, 2020
Merged

fix(worker): path.IsAbs is not working on windows #4901

merged 1 commit into from
Jan 20, 2020

Conversation

fsamin
Copy link
Member

@fsamin fsamin commented Jan 20, 2020

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 20, 2020

CDS Report build-all-cds#12114.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 20, 2020

CDS Report build-all-cds#12114.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@sguiheux sguiheux merged commit 527be9d into master Jan 20, 2020
@bnjjj
Copy link
Contributor

bnjjj commented Jan 21, 2020

I think filepath.IsAbs is windows compliant

@fsamin
Copy link
Member Author

fsamin commented Jan 21, 2020

I did not succeed to have expected results on windows dev setup :(

@fsamin fsamin deleted the fix/worker_windows branch January 31, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@sguiheux sguiheux sguiheux approved these changes

@richardlt richardlt richardlt approved these changes

@bnjjj bnjjj Awaiting requested review from bnjjj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fsamin @ovh-cds @bnjjj @yesnault @sguiheux @richardlt