Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(worker): use exported variables in further step #4908

Merged
merged 5 commits into from
Jan 23, 2020
Merged

fix(worker): use exported variables in further step #4908

merged 5 commits into from
Jan 23, 2020

Conversation

yesnault
Copy link
Member

without cds.build if not worker export

Signed-off-by: Yvonnick Esnault yvonnick.esnault@corp.ovh.com

@yesnault
fix(worker): use exported variables in further step
6316a18 
without cds.build if not worker export

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix(worker): unit test on cds.semver compute
6855731 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault yesnault marked this pull request as ready for review January 22, 2020 09:46
@yesnault
fix(worker): add some assertions
041d35e 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 22, 2020

CDS Report build-all-cds#12138.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@yesnault
fix(worker): add some logs
ff4b5c7 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 22, 2020

CDS Report build-all-cds#12147.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 22, 2020

CDS Report build-all-cds#12147.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✘
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 22, 2020

CDS Report build-all-cds#12148.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@yesnault
fix(worker): avoid flap ut
158ad5a 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@richardlt richardlt merged commit 22886fd into master Jan 23, 2020
@richardlt richardlt deleted the ye-fix-cds.build branch February 18, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamin fsamin fsamin approved these changes

@sguiheux sguiheux sguiheux approved these changes

@richardlt richardlt richardlt approved these changes

@bnjjj bnjjj Awaiting requested review from bnjjj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yesnault @ovh-cds @fsamin @sguiheux @richardlt