Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): use consumer name instead of username if service or worker #4909

Merged
merged 2 commits into from
Jan 23, 2020
Merged

fix(api): use consumer name instead of username if service or worker #4909

merged 2 commits into from
Jan 23, 2020

Conversation

richardlt
Copy link
Member

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 22, 2020

CDS Report build-all-cds#12140.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

golangcibot
golangcibot reviewed Jan 22, 2020
View reviewed changes
engine/api/worker.go Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 22, 2020

CDS Report build-all-cds#12141.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@fsamin fsamin merged commit c4f892c into master Jan 23, 2020
@richardlt richardlt deleted the fix-consumer-name-audits branch February 18, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@sguiheux sguiheux sguiheux approved these changes

@bnjjj bnjjj Awaiting requested review from bnjjj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@richardlt @ovh-cds @yesnault @fsamin @sguiheux @golangcibot