Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): register service check if already exists based on consumer #4914

Merged
merged 2 commits into from
Jan 24, 2020
Merged

fix(api): register service check if already exists based on consumer #4914

merged 2 commits into from
Jan 24, 2020

Conversation

richardlt
Copy link
Member

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 23, 2020

CDS Report build-all-cds#12170.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✘

fsamin
fsamin approved these changes Jan 23, 2020
View reviewed changes
engine/api/services.go Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 23, 2020

CDS Report build-all-cds#12173.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 24, 2020

CDS Report build-all-cds#12173.1 ■

  • Build
    • Build and Package All ■
    • Build Debpacker ■
    • Build OS-Ansible-Inventory ■
    • Build SMTPMock ■
    • Lint UI Translate ■
    • Test CLI ■
    • Test Engine ■
    • Test SDK ■
    • Test UI ■

richardlt and others added 2 commits January 24, 2020 09:38
@richardlt
fix(api): register service should check if a service exists based on …
5e3b1fa 
…consumer id
@richardlt @fsamin
Update engine/api/services.go
984655e 
Co-Authored-By: François Samin <francois.samin@corp.ovh.com>
@richardlt richardlt force-pushed the fix-multi-instances-for-services branch from 4500a83 to 984655e Compare January 24, 2020 08:38
@richardlt richardlt merged commit 7fbafaa into master Jan 24, 2020
@richardlt richardlt deleted the fix-multi-instances-for-services branch February 18, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@sguiheux sguiheux sguiheux approved these changes

@bnjjj bnjjj Awaiting requested review from bnjjj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@richardlt @ovh-cds @yesnault @fsamin @sguiheux