fix(plugin/marathon): avoid panic on timeout #4915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeout is checked by WaitOnDeployment this will avoid a panic like that: [INFO] Stopping plugin...Error on deployment xxxxx-xxxxx-xxxxx-xxxxx: the operation has timed out [INFO] panic: send on closed channel [INFO] [INFO] goroutine 50 [running]: [INFO] main.(*marathonActionPlugin).Run.func2(0x78, 0xc4202da050, 0xc420370230, 0xc420373a20, 0xb68620, 0xc4202f80f0, 0xc4202bcc60, 0x24) [INFO] /go/src/github.com/ovh/cds/contrib/grpcplugins/action/marathon/main.go:213 +0x1f2 [INFO] created by main.(*marathonActionPlugin).Run [INFO] /go/src/github.com/ovh/cds/contrib/grpcplugins/action/marathon/main.go:202 +0x1159 Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
yesnault
requested review from
bnjjj,
fsamin,
richardlt and
sguiheux
as code owners
richardlt
approved these changes
Jan 23, 2020
fsamin
approved these changes
Jan 23, 2020
sguiheux
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeout is checked by WaitOnDeployment
this will avoid a panic like that:
[INFO] Stopping plugin...Error on deployment xxxxx-xxxxx-xxxxx-xxxxx: the operation has timed out
[INFO] panic: send on closed channel
[INFO]
[INFO] goroutine 50 [running]:
[INFO] main.(*marathonActionPlugin).Run.func2(0x78, 0xc4202da050, 0xc420370230, 0xc420373a20, 0xb68620, 0xc4202f80f0, 0xc4202bcc60, 0x24)
[INFO] /go/src/github.com/ovh/cds/contrib/grpcplugins/action/marathon/main.go:213 +0x1f2
[INFO] created by main.(*marathonActionPlugin).Run
[INFO] /go/src/github.com/ovh/cds/contrib/grpcplugins/action/marathon/main.go:202 +0x1159
Signed-off-by: Yvonnick Esnault yvonnick.esnault@corp.ovh.com