fix(api): duplication of same node name is now forbidden #4953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
bnjjj
requested review from
fsamin,
richardlt,
sguiheux and
yesnault
as code owners
sguiheux
approved these changes
Feb 4, 2020
yesnault
approved these changes
Feb 4, 2020
fsamin
requested changes
Feb 4, 2020
engine/api/workflow/dao.go
Outdated
| nodeNames := make(map[string]struct{}, len(nodes)) | ||
| for i := range nodes { | ||
| if _, ok := nodeNames[nodes[i].Name]; ok { | ||
| return sdk.ErrWorkflowNodeNameDuplicate |
sguiheux
requested changes
Feb 4, 2020
sdk/error.go
Outdated
| @@ -382,6 +383,7 @@ var errorsAmericanEnglish = map[int]string{ | |||
| ErrBadBrokerConfiguration.ID: "Cannot connect to the broker of your event integration. Check your configuration", | |||
| ErrInvalidJobRequirementNetworkAccess.ID: "Invalid job requirement: network requirement must contains ':'. Example: golang.org:http, golang.org:443", | |||
| ErrWorkflowAsCodeResync.ID: "You cannot resynchronize an as-code workflow", | |||
| ErrWorkflowNodeNameDuplicate.ID: "You cannot have same name for different pipeline nodes in your workflow", | |||
sdk/error.go
Outdated
| @@ -563,6 +565,7 @@ var errorsFrench = map[int]string{ | |||
| ErrBadBrokerConfiguration.ID: "Impossible de se connecter à votre intégration de type évènement. Veuillez vérifier votre configuration", | |||
| ErrInvalidJobRequirementNetworkAccess.ID: "Pré-requis de job invalide: Le pré-requis network doit contenir un ':'. Exemple: golang.org:http, golang.org:443", | |||
| ErrWorkflowAsCodeResync.ID: "Impossible de resynchroniser un workflow en mode as-code", | |||
| ErrWorkflowNodeNameDuplicate.ID: "Vous ne pouvez pas avoir plusieurs fois le même nom de noeud de pipeline dans votre workflow", | |||
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
fsamin
approved these changes
Feb 4, 2020
sguiheux
approved these changes
Feb 4, 2020
richardlt
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Coenen 5719034+bnjjj@users.noreply.github.com
@ovh/cds