Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api,hatchery): take care of booked JobID #5156

Merged
merged 5 commits into from Apr 30, 2020
Merged

fix(api,hatchery): take care of booked JobID #5156

merged 5 commits into from Apr 30, 2020

Conversation

yesnault
Copy link
Member

No description provided.

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 29, 2020

CDS Report build-all-cds#13123.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@yesnault yesnault marked this pull request as ready for review April 29, 2020 15:02
fsamin
fsamin requested changes Apr 30, 2020
View reviewed changes
engine/api/workflow_queue.go Outdated Show resolved Hide resolved
engine/api/workflow_queue_test.go Outdated Show resolved Hide resolved
yesnault and others added 5 commits April 30, 2020 09:40
@yesnault
chore: jobID is mandatory on worker (registerOnly false)
525a77c 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
test: add assertion
4a12d6a 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: check JobID register / take
1c6665f 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: ut
89c2cfa 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault @fsamin
Apply suggestions from code review
b0a2c64 
Co-Authored-By: François Samin <francois.samin@corp.ovh.com>
@yesnault yesnault merged commit a5e7e0e into master Apr 30, 2020
@richardlt richardlt deleted the ye-bookjobid branch May 20, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamin fsamin fsamin approved these changes

@sguiheux sguiheux sguiheux approved these changes

@richardlt richardlt richardlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yesnault @ovh-cds @fsamin @sguiheux @richardlt